Re: [libvirt] [PATCH] Fix "virsh create" example
On Wed, Nov 07, 2012 at 02:46:24PM -0700, Eric Blake wrote:
On 11/07/2012 02:16 PM, Guido Günther wrote:
> We require a file and don't accept standard input:
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692322
> ---
> tools/virsh.pod | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
[We SHOULD accept stdin, perhaps only with the magic file name of '-',
but that's a lot more plumbing and affects a lot more commands, so this
is good for now]
Pushed on the basis that the current documentation is acually wrong. I
agree that supporting '-' is the solution.
Cheers,
-- Guido
>
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 0808d72..0984e6e 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -553,7 +553,7 @@ B<Example>
>
> virsh dumpxml <domain> > domain.xml
> vi domain.xml (or make changes with your other text editor)
> - virsh create < domain.xml
> + virsh create domain.xml
>
> =item B<define> I<FILE>
>
>
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org