Re: [libvirt] [PATCH] build: submodule machinery now works also when no tag is reachable
Daniel Veillard wrote:
On Wed, Jul 15, 2009 at 09:59:33AM +0200, Jim Meyering wrote:
> Mike Burns wrote:
> > I hit an issue with libvirt autobuild. I am running on an F11 machine and the
build stage of libvirt--devel is failing.
> ...
> > I talked to danpb and he pointed out that there is a difference between
.git-module-status and git submodule status:
> >
> > <danpb1> $ cat .git-module-status
> > <danpb1> -b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib
> > <danpb1> git submodule status
> > <danpb1> b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib
(v0.0-2286-gb653eda)
>
> Hi Mike,
>
> Thanks for the report, and thanks to Dan for looking into it.
> Here's a patch:
Hum, isn't the patch from Paolo Bonzini earlier a cleaner way to
avoid the - being inserted in the first place ?
Both patches work for gnulib. Mine is slightly more general in that
it would work also for a submodule with no signed tag, and
with an SHA1 for which no tag is an ancestor.