Re: [libvirt PATCH v2 5/7] ci: Don't mark any Fedora 36 job as optional
On Thu, May 26, 2022 at 04:23:44PM +0200, Erik Skultety wrote:
On Thu, May 26, 2022 at 04:01:50PM +0200, Andrea Bolognani wrote:
> +++ b/ci/manifest.yml
> @@ -157,7 +157,6 @@ targets:
> - arch: x86_64
>
> - arch: mingw32
> - allow-failure: true
There must be a hysterical raisin for this (not that I object to the patch),
maybe there was a bug in mingw toolchain giving us a hard time? I don't think
it has anything to do with the given OS's stability as the commit message
suggest, but if you don't remember and don't feel like digging, sure you can
keep the commit message as is.
I think it was simply carried over by mistake when the MinGW jobs
were added to stable Fedora after only having been executed on
Rawhide (where 'allow-failure: true' makes perfect sense) up until
that point.
The relevant commit is
commit c7edcb320be3ae6cfa3230f4d3b2c867db49a613
Author: Daniel P. Berrangé <berrange(a)redhat.com>
Date: Tue Nov 23 12:12:25 2021 +0000
ci: run a mingw64 job on stable Fedora
Both of the current mingw jobs are marked as 'allow_failure' because
they are running against Fedora rawhide which is an unstable distro.
We need at least one mingw job to be gating to more reliably detect
problems.
This introduces dockerfiles for both mingw variants on Fedora 35
and sets the mingw64 build to run on Fedora 34, and mingw32 on
Fedora rawhide.
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization