Jim Meyering wrote:
Dave Leskovec <dlesko@linux.vnet.ibm.com> wrote:
Jim Meyering wrote:
Dave Leskovec <dlesko@linux.vnet.ibm.com> wrote:
...
Index: b/qemud/qemud.c =================================================================== ... +static void sig_handler(int sig, siginfo_t * siginfo, + void* context ATTRIBUTE_UNUSED) { ... - unsigned char sigc; + siginfo_t siginfo; int ret;
- if (read(server->sigread, &sigc, 1) != 1) { + if (read(server->sigread, &siginfo, sizeof(siginfo)) != sizeof(siginfo)) {
Looks good, but that should be saferead instead of "read". Now that it's reading more than one byte, EINTR can make a difference.
This latest version of this patch changes the read() to a saferead() as Jim points out. -- Best Regards, Dave Leskovec IBM Linux Technology Center Open Virtualization