
On Mon, Jun 17, 2024 at 09:36:15AM GMT, Daniel P. Berrangé wrote:
On Fri, Jun 14, 2024 at 12:22:50PM -0400, Andrea Bolognani wrote:
This implementation allows things such as
-Dfirewall_backend_priority=nftables
and
-Dfirewall_backend_priority=iptables,iptables
At least
-Dfirewall_backend_priority=iptables,nftables,iptables
will be blocked, but only because it results in a compilation error: meson will happily accept it.
Are we okay with that? It's IMO inferior to the much stricter checking that's performed today.
I found that if you try this with meson you'll see this
DEPRECATION: Duplicated values in array option is deprecated. This will become a hard error in the future.
I think we're fine to delegate this to Meson, given its intent to turn this into a hard error eventually, since duplication is harmless for us in the short term.
I didn't realize that. Sounds good! -- Andrea Bolognani / Red Hat / Virtualization