Fixes the commented nitpicks[1].
I also provide an optional 3rd patch, that uses structs for address
and port ranges. There was a struct for DHCP address range that could be
used after a rename. I put the structs in virsocketaddr.h so they are
accessible from util/viriptables. I don't think it is worth its own
headerfile and sockaddr was what I thought was most relevant.
Skip the third patch if unsure.
Please CC me as i don't subscribe to the list.
Changes v5:
- Remove unused "longdef" leftover from rebase
- UseCamelCaseVariableNames
- Use virAsprintf instead of snprintf and avoid strings on stack
- Add an optional 3rd patch that uses structs for addr and port ranges.
Natanael Copa (3):
net: support set public ip range for forward mode nat
net: add support for specifying port range for forward mode nat
net: use structs for address and port ranges
docs/formatnetwork.html.in | 33 +++++++
src/conf/network_conf.c | 206 +++++++++++++++++++++++++++++++++++++++++---
src/conf/network_conf.h | 13 ++-
src/network/bridge_driver.c | 16 ++++
src/util/viriptables.c | 83 ++++++++++++++++--
src/util/viriptables.h | 4 +
src/util/virsocketaddr.h | 14 +++
7 files changed, 341 insertions(+), 28 deletions(-)
[1]
http://www.redhat.com/archives/libvir-list/2013-February/msg00817.html
--
1.8.1.3