Re: [libvirt] [PATCH v2 20/21] qemu: iothread: Aggregate code to set IOTrhead tuning
s/IOTrhead/IOThread/ in the summary
On Fri, Jan 29, 2016 at 05:02:15PM +0100, Peter Krempa wrote:
Rather than iterating 3 times for various settings this function
aggregates all the code into single place. One of the other advantages
is that it can then be reused for properly setting IOThread info on
hotplug.
This also adds the usage of autoCpuset for affinity.
---
src/qemu/qemu_cgroup.c | 93 ---------------------------
src/qemu/qemu_cgroup.h | 1 -
src/qemu/qemu_process.c | 165 +++++++++++++++++++++++++++++++++---------------
src/qemu/qemu_process.h | 2 +
4 files changed, 116 insertions(+), 145 deletions(-)
+
+ if (cpumask) {
+ if (virProcessSetAffinity(iothread->thread_id, cpumask) < 0)
+ goto cleanup;
+ }
This should be done after virCGroupAddTask, to preserve the order.
+
+ if (cgroup_iothread &&
+ virCgroupAddTask(cgroup_iothread, iothread->thread_id) < 0)
+ goto cleanup;
+
ACK with that fixed.
Jan
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)