Re: [PATCH] qemu_command: Generate memory only after controllers
On 2/2/22 14:34, Andrea Bolognani wrote:
On Wed, Feb 02, 2022 at 02:26:23PM +0100, Michal Prívozník wrote:
> On 2/2/22 13:44, Andrea Bolognani wrote:
>> Maybe we should add a test case where the memory device is not on the
>> root bus? We can't catch the QEMU error of course, but that would at
>> least serve as some sort of implicit documentation of the fact that
>> we expect that scenario to work.
>
> Sure, I can do that. I'm not that convinced on its value, but I can
> alter an existing test case.
If you don't think it's going to be useful, then just don't do it :)
Yeah, thing is, this bug depends on how QEMU behaves (namely order in
which it parses arguments). Libvirt produced "correct" output (in sense
that devices that need to be there are there). So unless we are starting
QEMU we won't notice the QEMU behavior.
Think of this in a different way, if QEMU started parsing arguments in
different order (highly improbable, but let's assume that for a while).
Even if I added test case as you suggest, our test suite would not
notice anything different, and yet - users would be unable to start
their guests.
But maybe I'm missing something and we might get something valuable from
such test? What was your thinking?
Michal