Am 29.10.2021 um 15:07 hat Eric Blake geschrieben:
On Mon, Oct 25, 2021 at 07:25:25AM +0200, Markus Armbruster wrote:
Add special feature 'unstable' everywhere the name starts with 'x-', except for InputBarrierProperties member x-origin and MemoryBackendProperties member x-use-canonical-path-for-ramblock-id, because these two are actually stable.
Signed-off-by: Markus Armbruster <armbru@redhat.com> --- @@ -2495,27 +2508,57 @@ # # Properties for throttle-group objects. # -# The options starting with x- are aliases for the same key without x- in -# the @limits object. As indicated by the x- prefix, this is not a stable -# interface and may be removed or changed incompatibly in the future. Use -# @limits for a supported stable interface. -# # @limits: limits to apply for this throttle group # +# Features: +# @unstable: All members starting with x- are aliases for the same key +# without x- in the @limits object. This is not a stable +# interface and may be removed or changed incompatibly in +# the future. Use @limits for a supported stable +# interface. +# # Since: 2.11 ## { 'struct': 'ThrottleGroupProperties', 'data': { '*limits': 'ThrottleLimits', - '*x-iops-total' : 'int', '*x-iops-total-max' : 'int',
+ '*x-iops-total': { 'type': 'int', + 'features': [ 'unstable' ] },
This struct has been around since 381bd74 (v6.0); but was not listed as deprecated at the time. Do we still need it in 6.2, or have we gone enough release cycles with the saner naming without x- that we could drop this? But that is a question independent of this patch.
There is no reason any more to use the x- options, and I think libvirt never used them anyway. I actually have a commit in my QAPI object branch that removes these properties, but I think it still broke some tests. Anyway, something for a separate patch. Kevin