Re: [libvirt] [PATCH] [2/4] Implement remote protocol for managed save

On 04/02/2010 04:56 PM, Daniel Veillard wrote:

diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index f86c7f1..0374f9a 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -1657,6 +1657,10 @@ struct remote_domain_has_managed_save_image_args { unsigned flags; };

+struct remote_domain_has_managed_save_image_ret { + int ret; +}; +

Hm, I don't think this is necessary. I think the return value is always going to be an int, so you should just be able to return -1, 0, or 1 in the remote driver as necessary. At least, that's how all of the other things that return numbers (such as virDomainNumDefinedDomains) work. -- Chris Lalancette