Re: [libvirt] [PATCH 1/2] network: added waiting for DAD to finish for bridge address.
On 08/04/2015 06:18 PM, Dmitry Guryanov wrote:
On 07/31/2015 07:35 PM, Maxim Perevedentsev wrote:
> +/* return after DAD finishes for all known IPv6 addresses or an
> error */
> +static int
> +networkWaitDadFinish(virNetworkObjPtr network)
I'd put this function to src/util/virnetlink.c
Then we should create list of
sockaddr_in6 to pass addresses and
netmasks to virnetlink.c since it should not include virNetwork*
structures. This will be double work I think.
> + //Parse response.
> + dad = networkParseDadStatus(resp, recvbuflen, network);
> + if (dad)
> + usleep(1000 * 10);
What if an interface will remain in transient state forever?
I think this is the
responsibility of kernel to update DAD state to
'success' or 'failed' to make interface leave transient state. In
addition, this is what was expected from dnsmasq in above commit.
--
Your sincerely,
Maxim Perevedentsev