On Thu, Apr 02, 2015 at 16:35:20 +0530, Prerna Saxena wrote:
Hi Peter,
While playing around with memory hotplug implementation, I found that the guest XML isnt updated after a successful hotplug operation :
[root@kop2 test-libvirt]# ./bin/virsh attach-device rhel71-be /home/prerna/mem-hp.xml Device attached successfully
[root@kop2 test-libvirt]# ./bin/virsh qemu-monitor-command rhel71-be --hmp "info memdev" memory backend: 0 size: 1073741824 merge: true dump: true prealloc: false policy: default host nodes:
[root@kop2 test-libvirt]# ./bin/virsh edit rhel71-be < Does not reflect an updated memory value or a separate dimm device >
After the attach-device command, the device should show up in the XML.
I have observed this on PowerKVM.
Wondering what is a good place to observe the hot-added memory : Should this reflect as an updated value for current memory in domain XML, or should this show up as a memory device of type:
<memory model='dimm'> <source> <pagesize unit='KiB'>4096</pagesize> <nodemask>1-3</nodemask> </source> <target> <size unit='KiB'>524287</size> <node>1</node> </target> </memory>
I would be happy to work on a patch to fix this. Pls provide me your thoughts.
If it does not it is a bug, but I'm not able to reproduce it, so go ahead and fix it if you want, or provide more information on why it happens. Thanks. Peter