Re: [libvirt] [PATCH 2/2] Introduce DOMAIN_DEVICE_ITERATE_MISSING_INFO

On Tue, 2019-05-21 at 16:26 +0200, Ján Tomko wrote: > Rename the DOMAIN_DEVICE_ITERATE_GRAPHICS flag. > It was introduced by commit dd45c2710f6fd2d4f8a47f97960532d0e0091e7d > with the intention to run the Validate callback even on the graphics > device. > > However, enumerating every single device in virDomainDeviceIterateFlags > is unsustainable and what really was special about the graphics device > was the lack of DeviceInfo. > > Rename the flag and iterate over more info-less devices. (and leases) > > Signed-off-by: Ján Tomko <jtomko(a)redhat.com&gt; > Inspired-by: Andrea Bolognani <abologna(a)redhat.com&gt; I very clearly voiced my disagreement with this approach, so please drop this tag before pushing.

ACK