Re: [Libvir] [PATCH] mark error messages as translatable
On Mon, Mar 24, 2008 at 12:26:51PM +0100, Jim Meyering wrote:
Daniel Veillard <veillard(a)redhat.com> wrote:
> On Sun, Mar 23, 2008 at 07:50:24PM +0100, Guido Günther wrote:
>> This patch marks the error messages in qemu_driver.c as translatable,
>> some of them were marked as such already. Please apply.
> [...]
>> qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
>> - "cannot create bridge '%s' : %s",
name, strerror(err));
>> + _("cannot create bridge '%s' : %)"),
name, strerror(err));
>
> Patch is a bit broken here, otherwise that looks fine. I'm wondering why
> that wasn't check by 'make syntax-check' as other modules are checked
for
> translatable strings.
I explained why, fixed the underlying problem,
and fixed about 1/3 of the violations it exposed
with this big patch:
http://thread.gmane.org/gmane.comp.emulators.libvirt/5374
But for your objection, I would have applied that change weeks ago.
I've been waiting for a reply to my question at the end of the thread:
http://thread.gmane.org/gmane.comp.emulators.libvirt/5374/focus=5382
My recollection is that I objected to a bunch of non-translatable strings
from the protocol module, Guido patch was about qemu_driver.c errors which
had translatable meaning. Maybe there is some overlap, but it looks different.
To me adding comments to C files to tag the fact that untranslatable strings
are now marked as translatable to allow an automatic check in the hope that
the translators will see those comments (with whatever tools they have) and
won't loose time on those strings didn't made much sense to me (and still
don't honnestly).
Either remove the check from the protocol module and and commit the other
parts, or just ignore me and commit the full thing. As you pointed out you're
not responsible for the multiplication of those debugging strings in that
module.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/