Thank you, Michal. I will read your comments carefully. It is great examples for me to learn more about the project. 2014-10-03 16:48 GMT+08:00 Michal Privoznik <mprivozn@redhat.com>:
On 02.10.2014 05:30, Taowei wrote:
This seriers of patches rewrite the vbox network driver.
Diff from v2: *Seperate the network driver from the domain driver. *Prevent vbox code from being compiled too many times when building network driver.
Taowei (14): vbox: Interfaces for register per parties vbox: Rewrite vboxNetworkOpen vbox: Rewrite vboxNetworkClose vbox: Rewrite vboxConnectNumOfNetworks vbox: Rewrite vboxConnectListNetworks vbox: Rewrite vboxConnectNumOfDefinedNetworks vbox: Rewrite vboxConnectListDefinedNetworks vbox: Rewrite vboxNetworkLookupByUUID vbox: Rewrite vboxNetworkLookupByName vbox: Rewrite vboxNetworkDefineCreateXML vbox: Rewrite vboxNetworkUndefineDestroy vbox: Rewrite vboxNetworkCreate vbox: Rewrite vboxNetworkGetXMLDesc vbox: New network driver
po/POTFILES.in | 1 + src/Makefile.am | 16 +- src/vbox/vbox_common.c | 70 +- src/vbox/vbox_common.h | 16 + src/vbox/vbox_driver.c | 55 +- src/vbox/{vbox_install_api.h => vbox_get_driver.h} | 9 +- src/vbox/vbox_network.c | 1050 ++++++++++++++++ src/vbox/vbox_tmpl.c | 1261 +++++--------------- src/vbox/vbox_uniformed_api.h | 52 + 9 files changed, 1523 insertions(+), 1007 deletions(-) rename src/vbox/{vbox_install_api.h => vbox_get_driver.h} (79%) create mode 100644 src/vbox/vbox_network.c
I'm fixing all the small nits I've found, ACKing and pushing. Awesome job - the compilation is somewhat faster again. Thanks!
Michal