Re: [libvirt] [PATCH] qemu: capabilities: Don't partially reprope caps on process reconnect
On Mon, Nov 28, 2016 at 10:59:35 +0100, Boris Fiuczynski wrote:
Peter,
besides the trivial typo in the subject line (s/reprope/reprobe) I agree
that this is the correct fix for the capability problem when reconnecting to
the qemu processes. Thanks.
I suggest that you mention in the patch description that libvirt starting
with version 2.2.0 is terminating all running qemu domains if the qemu
binaries do not implement/have not enabled the qmp command
'query-hotpluggable-cpus'.
Including the user observable internal error message for reference would
maybe help as well. (internal error: unable to execute QEMU command
'query-hotpluggable-cpus': The feature 'query-hotpluggable-cpus' is not
enabled)
I've already pushed it with the original message, right after Jiri's
review.
In addition this patch looks to me like a good candidate for the
maintenance
branches.
I've backported it to v2.2-maint. There are no other maint branches
after that.
Tested-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com>
Peter
Attachments:
- signature.asc (application/pgp-signature — 801 bytes)