Re: [libvirt] [PATCH 4/5] util: Add virStringHasSuffix()

On Wed, Mar 06, 2019 at 17:54:03 +0100, Andrea Bolognani wrote:

This is the case-sensitive counterpart of the existing virStringHasCaseSuffix() function.

Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/util/virstring.c | 13 +++++++++++++ src/util/virstring.h | 2 ++ 2 files changed, 15 insertions(+)

diff --git a/src/util/virstring.c b/src/util/virstring.c index b4d10f9884..b9b33e3d1a 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1235,6 +1235,19 @@ virStringReplace(const char *haystack, return virBufferContentAndReset(&buf); }

+int

Why doesn't this return bool?

+virStringHasSuffix(const char *str, + const char *suffix)

ACK with appropriate return type.