Re: [libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

On Mon, 2018-02-19 at 07:28 +0100, Peter Krempa wrote: > On Fri, Feb 16, 2018 at 17:28:04 +0100, Andrea Bolognani wrote: > > We will rewrite pretty much every single line of this function > > over the course of the next several commits, and starting from > > a clean slate rather than replacing it bit by bit makes the > > resulting diffs unmeasurably easier to read and understand, > > and you need fewer of them to boot. Trust me, I tried the other > > approach first :) > > Will this remove any checks during the series? If yes, then you probably > should at first rename this function and add a almost-empty wrapper then > add new code to the wrapper and delete the renamed function at the end. No, if anything it *adds* a bunch of checks :)

Renaming the function won't work because then the compiler will complain about it being unused. Unless you meant something like /* Delete once done */ ValidateControllerPCIOld() { /* Existing checks here */ } ValidateControllerPCI() { /* New checks here */ /* Delete once done */ ValidateControllerPCIOld(); } which could actually do the trick.