Re: [libvirt] [PATCH 3/8] Implement Block Io Throttle setting for the qemu driver

27 Oct 2011


      On Thu, Oct 27, 2011 at 05:20:05PM +0800, Lei HH Li wrote:
...
+    if (flags) {
+        ret = virAsprintf(&cmd, "block_set_io_throttle %s %llu %llu %llu %llu %llu %llu",
+                                 device,
+                                 info->bps,
+                                 info->bps_rd,
+                                 info->bps_wr,
+                                 info->iops,
+                                 info->iops_rd,
+                                 info->iops_wr);
Please combine the parameters onto fewer lines.

-- 
Adam Litke <agl@us.ibm.com>
IBM Linux Technology Center