On Wed, Feb 03, 2021 at 10:10:11 +0100, Pavel Hrdina wrote:
On Wed, Feb 03, 2021 at 08:45:52AM +0100, Peter Krempa wrote:
On Tue, Feb 02, 2021 at 16:04:08 +0100, Pavel Hrdina wrote:
Make the function reusable by other vhost-user based devices.
Since reusability is the goal ...
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_validate.c | 99 +++++++++++++++++++++------------------- 1 file changed, 51 insertions(+), 48 deletions(-)
[...]
Is this reasonable documentation:
+/** + * qemuValidateDomainDefVhostUserRequireSharedMemory: + * @def: VM definition + * @name: name of the attribute/element + * @qemuCaps: capabilities of QEMU binary + * + * Check if the VM definition contains any form of shared memory + * which is required by vhost-user devices to operate properly. + * + * On success returns 0, on error returns -1 and reports proper error + * message.
Yes, that sounds good.