Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

Jim Meyering wrote: > Cole Robinson <crobinso(a)redhat.com&gt; wrote: >> parted doesn't seem to want the label 'dos', instead >> wanting 'msdos'. Patch is basically s/dos/msdos/ > > Hi Cole, > > This definitely needs to be fixed. > > FYI, "dos" appears to be the preferred name for that partition table type > (google for "partition table" and either "dos" or "msdos"; also, partx > --type accepts "dos", not "msdos"). Too bad Parted added the "ms" prefix. > If it's not hard to implement, it would be nice to hide the implementation > detail that Parted happens to call it the "msdos" label type. > We could just keep the outward facing label the same, and internally map it to use msdos if calling 'parted mklabel' since it's the only command that seems to use that value. Whatever people think is best.