On Wed, Oct 23, 2019 at 12:43:02 +0200, Andrea Bolognani wrote:
Now that the only data we need for fully testing a QEMU binary is the (version, arch) combo, we can stop providing that information ourselves and instead rely on testQemuCapsIterate() automatically picking up new input files as they are added to the repository, the same way the qemucapabilities and qemucaps2xml tests already behave.
Unsurprisingly, this change results in a bunch of extra output files being created, significantly expanding our test coverage.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> ... + /* + * Run "tests/qemucapsprobe /path/to/qemu/binary >foo.replies" + * to generate updated or new *.replies data files. + * + * If you manually edit replies files you can run + * "tests/qemucapsfixreplies foo.replies" to fix the replies ids. + * + * Once a replies file has been generated and tweaked if necessary, + * you can drop it into tests/qemucapabilitiesdata/ (with a sensible + * name - look at what's already there for inspiration) and test + * programs will automatically pick it up. + * + * To generate the corresponding output files after a new replies + * file has been added, run "VIR_TEST_REGENERATE_OUTPUT=1 make check". + */
I'd just suggest running VIR_TEST_REGENERATE_OUTPUT=1 tests/qemucapabilitiestest followed by VIR_TEST_REGENERATE_OUTPUT=1 tests/domaincapstest For the whole series: Reviewed-by: Jiri Denemark <jdenemar@redhat.com>