Re: [libvirt] [PATCH] docs: introduce libvirt-dbus binding

On Fri, Mar 23, 2018 at 10:15:58AM +0000, Daniel P. Berrangé wrote: > On Fri, Mar 23, 2018 at 08:35:34AM +0100, Pavel Hrdina wrote: > > libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. > > > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > > --- > > docs/bindings.html.in | 4 ++ > > docs/dbus.html.in | 102 +++++++++++++++++++++++++++++++++++++++++++++++++ > > docs/docs.html.in | 1 + > > docs/downloads.html.in | 15 ++++++++ > > 4 files changed, 122 insertions(+) > > create mode 100644 docs/dbus.html.in > > > > diff --git a/docs/downloads.html.in b/docs/downloads.html.in > > index 7c28e2ba9b..c2bc7af3e9 100644 > > --- a/docs/downloads.html.in > > +++ b/docs/downloads.html.in > > @@ -60,6 +60,21 @@ > > </td> > > <td></td> > > </tr> > > + <tr> > > + <td>D-Bus</td> > > + <td> > > + <a href="ftp://libvirt.org/libvirt/dbus/">ftp</a> > > + <a href="https://libvirt.org/sources/dbus/">https</a> > > + </td> > > + <td> > > + <a href="https://libvirt.org/git/?p=libvirt-dbus.git;a=summary">... > > + </td> > > + <td> > > + <a href="https://gitlab.com/libvirt/libvirt-dbus">gitlab</a> > > + <a href="https://github.com/libvirt/libvirt-dbus">github</a> > > + </td> > > + <td></td> > > + </tr> > > This should go in the "Integration modules" section, rather than the > "language bindings" section of the table. In that case I should also remove it from all places that list bindings. I'll put a link to the dbus.html page into "Resources" column on the download page since there is no better place where to mention it.

> If that's changed & the DOCTYPE thing, then > > Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; Thanks, Pavel