Re: [libvirt] [PATCH v3 14/48] remote: refactor & rename variables for building libvirtd
On Mon, 2019-07-29 at 18:10 +0100, Daniel P. Berrangé wrote:
[...]
LIBSOCKET is dropped as it is only set on Windows and we don't
build the libvirtd daemon under mingw.
Even though you at least mention it in the commit message...
-libvirtd_LDADD += \
- ../gnulib/lib/libgnu.la \
- $(LIBSOCKET) \
- $(NULL)
... I still feel like this should have been its own commit, since
it's completely unrelated to what you're doing here. But I'm not
going to insist too much, so even if you leave it as-is you still
get a
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization