On 09/03/14 23:25, Eric Blake wrote:
I'm about to add a syntax check that enforces our documented
HACKING style of always using matching {} on if-else statements.
This patch focuses on code shared between multiple drivers.
* src/conf/domain_conf.c (virDomainFSDefParseXML)
(virSysinfoParseXML, virDomainNetDefParseXML)
(virDomainWatchdogDefParseXML)
(virDomainRedirFilterUSBDevDefParseXML): Correct use of {}.
* src/conf/interface_conf.c (virInterfaceDefParseDhcp)
(virInterfaceDefParseIp, virInterfaceVlanDefFormat)
(virInterfaceDefParseStartMode, virInterfaceDefParseBondMode)
(virInterfaceDefParseBondMiiCarrier)
(virInterfaceDefParseBondArpValid): Likewise.
* src/conf/node_device_conf.c (virNodeDevCapStorageParseXML):
Likewise.
* src/conf/nwfilter_conf.c (virNWFilterRuleDetailsParse)
(virNWFilterRuleParse, virNWFilterDefParseXML): Likewise.
* src/conf/secret_conf.c (secretXMLParseNode): Likewise.
* src/cpu/cpu_x86.c (x86Baseline, x86FeatureLoad, x86ModelLoad):
Likewise.
* src/network/bridge_driver.c (networkKillDaemon)
(networkDnsmasqConfContents): Likewise.
* src/node_device/node_device_hal.c (dev_refresh): Likewise.
* src/nwfilter/nwfilter_gentech_driver.c (virNWFilterInstantiate):
Likewise.
* src/nwfilter/nwfilter_ebiptables_driver.c
(_iptablesCreateRuleInstance): Likewise.
* src/storage/storage_backend_disk.c
(virStorageBackendDiskBuildPool): Likewise.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
src/conf/domain_conf.c | 30 ++++++++---------
src/conf/interface_conf.c | 56 ++++++++++++++++---------------
src/conf/node_device_conf.c | 4 +--
src/conf/nwfilter_conf.c | 27 ++++++++++-----
src/conf/secret_conf.c | 12 +++----
src/cpu/cpu_x86.c | 18 +++++-----
src/network/bridge_driver.c | 8 ++---
src/node_device/node_device_hal.c | 3 +-
src/nwfilter/nwfilter_ebiptables_driver.c | 4 +--
src/nwfilter/nwfilter_gentech_driver.c | 5 +--
src/storage/storage_backend_disk.c | 4 +--
11 files changed, 92 insertions(+), 79 deletions(-)
ACK,
Peter