Re: [libvirt] [python PATCH] maint: document development against uninstalled libvirt

On Mon, Jun 30, 2014 at 02:53:04PM +0200, Martin Kletzander wrote: > On Wed, Jun 25, 2014 at 11:12:52AM -0600, Eric Blake wrote: > >On 06/25/2014 10:59 AM, Peter Krempa wrote: > >>On 06/25/14 18:53, Eric Blake wrote: > >>>Thanks to Dan's recent work in libvirt.git, it is much easier to > >>>develop against uninstalled libvirt. Mention how. > >>> > >>>* README: More details. > >>> > >>>Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > >>>--- > >>> README | 15 +++++++++++++++ > >>> 1 file changed, 15 insertions(+) > >>> > >> > >>ACK, > > > >Thanks; pushed. > > > >FYI: I'm also using this (but considered it hackish enough to not > >publish as a formal patch): > > > >$ echo /GNUmakefile >> .git/info/exclude > >$ cat GNUmakefile > ># My hidden wrapper to preset things that I like... > >include Makefile > >export LD_LIBRARY_PATH=/home/eblake/libvirt/src/.libs/ > >export PKG_CONFIG_PATH=/home/eblake/libvirt/src/ > >$ > > > > For people like me, who use 'git clean -fxd'; it removes such > excludes. :( > > How about either adding similar GNUmakefile, of modifying the Makefile > you added into the repo liike this" > > The path used for the exports would be something like: > $(pwd | sed -e 's_/libvirt\(\.git\)\?/_/libvirt-python\1/') > but only if such path exists. There would be nothing changed for > those who do not have such paths. It could be also hidden under some > other make command (e.g. make devel). > > Does that make sense or is it not worth trying to do that at all? IMHO this GNUmakefile Eric suggests is just duplicating what the 'run' script already does. eg if you have libvirt & libvirt-python checked out at the same place, you can just do '../libvirt/run make' or '../libvirt run python setup.py build'

Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|