On Mon, Oct 06, 2025 at 12:17:30PM +0100, Daniel P. Berrangé via Devel wrote:
My previous RPM fix was wrong, as sanlock can actually be used with libxl too. It is the meson rules that were wrong.
I could've foresee this, but both your previous fix and Cole's patch together made sense... if blindly trusting our meson.build, which, it turns out, is not only source of the perfect truth O:-)
Daniel P. Berrangé (2): Revert "rpm: disable sanlock when QEMU is disabled" locking: use & install test_libvirt_sanlock.sug for both QEMU & LibXL
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
libvirt.spec.in | 4 ++-- src/locking/libvirt_sanlock.aug | 1 + src/locking/meson.build | 16 ++++++++-------- 3 files changed, 11 insertions(+), 10 deletions(-)
-- 2.50.1