Re: [libvirt] [PATCH v2 4/7] qemu: Use helper functions for handling cmd line capabilities

On 02/22/2011 09:48 AM, Jiri Denemark wrote: I didn't spot any obvious changes from v1. The only remaining hits for 'git grep "qemuCmdFlags &"' were in docs/api_extension; but rewriting past patches is an awkward game to play, so I'm fine with leaving them alone. You missed my comment against v1 about at least mentioning the names of the new helper methods in the commit message, so that 'git log' makes it easier to search for their introduction: https://www.redhat.com/archives/libvir-list/2011-February/msg00264.html 'git grep "|= QEMU_CAPS"' shows that you missed a change that happened since v1: tests/qemuxml2argvtest.c added 'flags |= QEMU.*PCI_MULTIBUS', which should be converted as well (although I'm sure that it gets re-converted later in this series, we might as well make each patch complete rather than relying on later patches to touch it up). ACK with those two nits fixed. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org