Re: [Libvir] [PATCH] When reporting errors, use "conn" whenever possible.

27 Nov 2007


      Daniel Veillard <veillard@redhat.com> wrote:
...
On Tue, Nov 27, 2007 at 03:34:14PM +0100, Jim Meyering wrote:
...
Here's a first cut at cleaning up.
There are more ab/uses in other files, but nowhere near as
many as in this one, so I'm starting here:
When reporting errors, use "conn" whenever possible.
* src/remote_internal.c: change all error (NULL, ... to error (conn, ...
          (check_cert_file): Add+use parameter, conn.
          Adjust callers.
          (initialise_gnutls): The "conn" parameter *is* used, so remove
          ATTRIBUTE_UNUSED.
          Suggested by Richard Jones.
If not, no big deal.
I can rewrite it.