[libvirt] [PATCH 6/6] virObjectEventNew: Use virObjectUnref() to free virObjectEvent
While no leak was observed yet, there might be one if
virObjectEventClass is ever derived from another class. Because
in that case plain VIR_FREE() will not call dispose() from parent
classes possibly leaking some memory.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/conf/object_event.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/conf/object_event.c b/src/conf/object_event.c
index bbef7f6..b5a6a81 100644
--- a/src/conf/object_event.c
+++ b/src/conf/object_event.c
@@ -649,13 +649,9 @@ virObjectEventNew(virClassPtr klass,
event->eventID = eventID;
event->remoteID = -1;
- if (VIR_STRDUP(event->meta.name, name) < 0) {
- VIR_FREE(event);
- return NULL;
- }
- if (VIR_STRDUP(event->meta.key, key) < 0) {
- VIR_FREE(event->meta.name);
- VIR_FREE(event);
+ if (VIR_STRDUP(event->meta.name, name) < 0 ||
+ VIR_STRDUP(event->meta.key, key) < 0) {
+ virObjectUnref(event);
return NULL;
}
event->meta.id = id;
--
2.8.4