On Thu, May 12, 2016 at 10:30:24 +0200, Ján Tomko wrote:
On Wed, May 11, 2016 at 03:47:06PM -0600, Jim Fehlig wrote:
On 05/11/2016 04:57 AM, Ján Tomko wrote:
An alternative to https://www.redhat.com/archives/libvir-list/2016-May/msg00700.html 1462942877-31516-1-git-send-email-jfehlig@suse.com
This series adds a call to DeviceDefPostParse for the implicit video which is being in the DomainDefPostParse phase, after DeviceDefPostParse has been done on all the existing devices.
I much prefer this approach over fixing it in the driver, but I'm not terribly familiar with this code, hence the attempt to fix it in libxl.
Ján Tomko (3): Move virDomainDefPostParseInternal after virDomainDeviceDefPostParse Call per-device post-parse callback even on implicit video Fill out default vram in DeviceDefPostParse
I reviewed and tested the patches and did not notice any problems - ACK series.
Thanks, pushed now.
This broke few parts of the xen testsuite: TEST: xmconfigtest .!.!.!.!.....!.!.!.!.!.!.!.!.!.!.!.!.!.! 40 .!.!.!.!.!.!.!.!!.!.!.! 63 FAIL TEST: xlconfigtest ...!!!.!.!.!.!.....!.!.!!! 26 FAIL TEST: sexpr2xmltest .!.!!!!!.........!....!..!!!!.!!!!!!!!!! 40 !!!!!!!!.! 50 FAIL Some examples: 59) Xen XM-2-XML Format escape-paths ... In '/home/pipo/libvirt/tests/xmconfigdata/test-escape-paths.xml': Offset 1942 Expect [h] Actual [vram='16384' h]