Re: [libvirt] [RFC PATCH 4/5] util: storagefile: Add deep copy for struct virStorageSource

On 06/12/2014 09:02 AM, Peter Krempa wrote: > Now that we have pointers to store disk source information and thus can > easily exchange the structs behind we need a function to copy all the > data. > --- > src/libvirt_private.syms | 1 + > src/util/virstoragefile.c | 150 ++++++++++++++++++++++++++++++++++++++++++++++ > src/util/virstoragefile.h | 2 + > 3 files changed, 153 insertions(+) > > +virStorageSourcePtr > +virStorageSourceCopy(const virStorageSource *src, > + bool backingChain) > +{ > + size_t i; > + virStorageSourcePtr ret = NULL; > + > + if (VIR_ALLOC(ret) < 0) > + return NULL; > + > + ret->type = src->type; > + ret->protocol = src->protocol; > + ret->format = src->format; > + ret->allocation = src->allocation; > + ret->capacity = src->capacity; > + ret->backingRelative = src->backingRelative; If I'm not mistaken, backingRelative disappears in your other series; I'm guessing you plan on rebasing that on top of this to pick up on the easier semantics. > + > + /* storage driver metadata are not copied */ > + ret->drv = NULL; Seems okay, particularly since doing a deep copy of that would require callback functions in the storage drivers.