Re: [PATCH 0/8] Enabling logging for ch guests

On 12/6/24 18:47, Praveen K Paladugu wrote: > LogContext management is now moved from Qemu driver to hypervisor. After migrating Qemu to use domain_logcontext, I extended ch driver to use also use logcontext to capture early boot failures in domain specific log file. > > I broke up the migration of logcontext from qemu to hypevisor into multiple patches. Due to this breakup, patches 1,2,3 fail to build. Only after applying patch4 does this patchset successfully build. > > Praveen K Paladugu (8): > domain: move logcontext mgmt from qemu to hypervisor > hypervisor: drop hypervisor specific args in domainLogContextNew > qemu: Fix domainLogContextNew invocations in qemu driver > libvirt_private: export symbols from domain_logcontext > po: Update POTFILES > ch: Enable logging for ch domains > ch: move curl_data and curl_callback definitions > ch: Enable logging curl responses from ch > > po/POTFILES | 2 +- > src/ch/ch_conf.h | 2 + > src/ch/ch_monitor.c | 84 ++++++++++++------- > src/ch/ch_monitor.h | 6 +- > src/ch/ch_process.c | 36 ++++++-- > .../domain_logcontext.c} | 78 +++++++++-------- > src/hypervisor/domain_logcontext.h | 45 ++++++++++ > src/hypervisor/meson.build | 1 + > src/libvirt_private.syms | 6 ++ > src/qemu/meson.build | 1 - > src/qemu/qemu_domain.c | 28 +++---- > src/qemu/qemu_domain.h | 12 +-- > src/qemu/qemu_logcontext.h | 41 --------- > src/qemu/qemu_nbdkit.c | 12 ++- > src/qemu/qemu_process.c | 45 +++++----- > 15 files changed, 235 insertions(+), 164 deletions(-) > rename src/{qemu/qemu_logcontext.c => hypervisor/domain_logcontext.c} (79%) > create mode 100644 src/hypervisor/domain_logcontext.h > delete mode 100644 src/qemu/qemu_logcontext.h > The end result looks fine, but we require that code base compiles and tests pass after each commit (because it helps downstream maintainers). Can you please fix that in v2? Michal