Re: [libvirt] [PATCH 1/2] qemu: correct misspelled 'enospc' option, and only use for werror
On 10/04/2011 03:17 PM, Eric Blake wrote:
On 10/04/2011 12:35 PM, Laine Stump wrote:
> This resolves:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=730909
>
> When support for setting the qemu disk error policy to 'enospc' was
> added, it was inadvertantly as "enospace". This patch corrects that on
spelling and grammar
s/inadvertantly/inadvertently spelled/
You have to appreciate the irony, though, right? :-)
> the qemu commandline (while retaining the "enospace" spelling for
> libvirt's XML.
>
> Also, while examining the qemu source, I found that "enospc" is not
> allowed for the read error policy, only for write error policy (makes
> sense). Since libvirt currently only has a single error policy
> setting, when "enospace" is selected, the read error policy is set to
> "ignore".
> ---
> src/qemu/qemu_command.c | 22 ++++++++++++++++++----
> 1 files changed, 18 insertions(+), 4 deletions(-)
ACK.
Okay, I'm pushing this one without waiting for 2/2, though, as I haven't
decided how to deal with some of the issues you brought up in your review.