Re: [libvirt] [PATCH v2 2/4] util: virhostcpu: factor out frequency parsing

> + if (!prefix) { > + VIR_WARN("Parser for /proc/cpuinfo needs to be adapted for your architecture"); > + return 1; I'd print the architecture in the warning, so sysadmins can see easily which architecture it is, even when looking at logs collected from different libvirt installations.

> + while (fgets(line, sizeof(line), cpuinfo) != NULL) { > + if (!STRPREFIX(line, prefix)) > + continue; IMHO here it would be a good idea to check that line[strlen(prefix)] is either a space or ':', to avoid prefix matching more keys than the actual intended one(s) -- something like: char c = line[strlen(prefix)]; if (c != ':' && !c_isspace(*str)) continue;