Re: [libvirt] [PATCH v2 2/2] m4: Add warning when running QEMU as root

On Tue, Mar 26, 2019 at 05:06:16PM +0100, Andrea Bolognani wrote: > Running QEMU as root is a pretty bad idea, so try to make the > user aware of that as part of the configure summary. > > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com&gt; > --- > m4/virt-driver-qemu.m4 | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4 > index 5d4ac66a4b..a8b9fe54b3 100644 > --- a/m4/virt-driver-qemu.m4 > +++ b/m4/virt-driver-qemu.m4 > @@ -104,5 +104,10 @@ AC_DEFUN([LIBVIRT_DRIVER_RESULT_QEMU], [ > ]) > > AC_DEFUN([LIBVIRT_RESULT_QEMU_PRIVILEGES], [ > - LIBVIRT_RESULT([QEMU], [$QEMU_USER:$QEMU_GROUP]) > + if test "$QEMU_USER" = "root"; then > + LIBVIRT_RESULT([QEMU], [$QEMU_USER:$QEMU_GROUP], > + [!!! running QEMU as root is strongly discouraged !!!]) Am I evil for suggesting use of blink :-P

[\033[31;5m running QEMU as root is strongly discouraged \033[0m]) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list