[libvirt] [PATCH 3/4] storage: FS backend adjust error message on error path
https://bugzilla.redhat.com/show_bug.cgi?id=1181087
Currently the assumption on the error message is that there are
no source device path's defined when the != 1 check fails, but in
reality the value could 0 or 2 or more, so adjust the error message
accordingly to make it clearer what the error really is.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/storage/storage_backend_fs.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index 9a1343d..3c39646 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -362,8 +362,13 @@ virStorageBackendFileSystemValidateFS(virStoragePoolObjPtr pool)
}
} else {
if (pool->def->source.ndevice != 1) {
- virReportError(VIR_ERR_INTERNAL_ERROR,
- "%s", _("missing source device"));
+ if (pool->def->source.ndevice == 0)
+ virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+ _("missing source device"));
+ else
+ virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+ _("Expected exactly 1 device for the "
+ "storage pool"));
return -1;
}
}
--
2.1.0