Re: [libvirt] PATCH: 1/2: port Test driver to network APIs

> static virNetworkPtr testNetworkCreate(virConnectPtr conn, const char *xml) { > - int handle = -1; > - virNetworkPtr net; > + virNetworkDefPtr def; > + virNetworkObjPtr net; > GET_CONNECTION(conn, NULL); > > - if (xml == NULL) { > - testError(conn, NULL, NULL, VIR_ERR_INVALID_ARG, __FUNCTION__); > - return (NULL); > - } > + if ((def = virNetworkDefParse(conn, xml, NULL)) == NULL) > + return NULL; > > - if (privconn->numNetworks == MAX_NETWORKS) { > - testError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, _("too many networks")); > - return (NULL); > - } > + if ((net = virNetworkAssignDef(conn, &privconn->networks, > + def)) == NULL) Don't we need to call virNetworkDefFree(def) before returning?