Re: [libvirt] [PATCH 00/11] Generic data stream handling

> 1) Immediately after starting the stream, I get a virStreamRecv() callback on > the destination side. The problem is that this is wrong for migration; there's > no data that I can read *from* the destination qemu process which makes any > sense. While I could implement the method and just throw away the data, that > doesn't seem right to me. This leads to... I realize this is due to the remoteAddClientStream() method in qemud/stream.c. It unconditionally sets 'stream->tx' to 1. I didn't notice the problem myself, since the test driver is using pipes which are unidirectional, but yor UNIX domain socket is bi-directional. We could either add a flag to remoteAddClientStream() to indicate whether the stream should allow read or write or both. Or you might be able to call shutdown(sockfd, SHUT_RD) on your UNIX socket to indicate that its only going to be used for write effectively making it unidirectional.