Re: [libvirt] Libvirt xl to xml converter only picks up first occurrence of an option

On 10/20/2017 08:46 AM, Wei Liu wrote: > Hi Jim Hi Wei, Sorry for the delay. Catching up on mail after some days off... > I discovered that libvirt's native config file to xml converter for > libxl only pick up the first occurrence of an option. > > For example in a xl cfg file: > > extra = "abc" > ... > extra = "def" > > xl will pick up "def" because that shows up later and takes precedence, > while the converter picks up "abc". > > I think this is a bug in the converter and should be fixed. Thanks for the report. I took a quick peek at libvirt's generic config parser and afaict it only searches for the first occurrence of a setting. The parser does support flags though, so we could add something like VIR_CONF_FLAG_{FIRST,LAST}_DUPLICATE. (Better name suggestions welcomed.)

I've opened a bug report against openSUSE Factory to track this https://bugzilla.opensuse.org/show_bug.cgi?id=1065118