On Thu, May 16, 2024 at 10:24:19AM +0200, Andrea Bolognani wrote:
The ssh-proxy feature works independently of the clients, just like the NSS plugin does.
Moreover, ssh-proxy only works for local VMs, while clients are routinely used to manage remote hypervisors.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- libvirt.spec.in | 3 --- 1 file changed, 3 deletions(-)
Yes, I guess this is ultimately pointless, as if the users picked the libvirt-daemon-{qemu,kvm} convenience RPMs, they'll have the SSH proxy installed regardless. If they didn't pick that and selected individual RPMs, without libvirt-ssh-proxy, then we should not be pulling it in anyway with the client. Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
diff --git a/libvirt.spec.in b/libvirt.spec.in index f7c128d809..5cb19fa433 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1025,9 +1025,6 @@ Summary: Client side utilities of the libvirt library Requires: libvirt-libs = %{version}-%{release} # Needed by virt-pki-validate script. Requires: gnutls-utils - %if %{with_ssh_proxy} -Recommends: libvirt-ssh-proxy = %{version}-%{release} - %endif
# Ensure smooth upgrades Obsoletes: libvirt-bash-completion < 7.3.0 -- 2.45.0
With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|