Re: [libvirt] [PATCH] libvirt_public.syms: Fix virDomainSetBlockThreshold placement

On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privoznik wrote: > The symbol was introduced in the 3.2.0 release (bb09798fbeb5f) > and not 3.1.0 release as its current placement in the file > suggests. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > src/libvirt_public.syms | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms > index 428cf2e..37a8a18 100644 > --- a/src/libvirt_public.syms > +++ b/src/libvirt_public.syms > @@ -755,8 +755,12 @@ LIBVIRT_3.0.0 { > > LIBVIRT_3.1.0 { > global: > - virDomainSetBlockThreshold; > virDomainSetVcpu; > } LIBVIRT_3.0.0; > > +LIBVIRT_3.2.0 { > + global: > + virDomainSetBlockThreshold; > +} LIBVIRT_3.1.0; > + > # .... define new API here using predicted next version number .... Oh, this is unfortunate. But doesn't this change break ABI?