Re: [libvirt] [PATCH v6 01/13] qemu: Add QEMU 2.10 x86_64 the generated capabilities

31 Aug 2017


      On Thu, Aug 31, 2017 at 09:56:46 +0200, Peter Krempa wrote:
...
On Wed, Aug 30, 2017 at 18:46:01 -0400, John Ferlan wrote:
[...]
...
...
scrubbed the file slightly to set qemuctime, selfctime, and
selfvers to 0 and change the package to add a "-dirty".
[...]
...
...
+{
+  "QMP": {
+    "version": {
+      "qemu": {
+        "micro": 94,
+        "minor": 9,
+        "major": 2
+      },
+      "package": " (v2.10.0-rc4-dirty)"
What changes do you have on top of rc4?
I've actually noticed that you've added the '-dirty' part manually? Why?
That does not make any sense. '-dirty' is added if you have uncommited
changes in the qemu repo, which actually should not be used as a source
of capabilities in libvirt.