On 10/16/19 11:19 PM, Mao Zhongyi wrote:
A function virStringParseYesNo was added to convert string 'yes' to true and 'no' to false, so use this helper to replace 'STREQ(.*, \"yes\")' and 'STREQ(.*, \"no\")' as it allows us to drop several repetitive if-then-else string->bool conversion blocks.
v2->v1
p1: - ignore the return value of virStringParseYesNo. - update the commit message. [Michal Privoznik]
p2: - add the Acked-by tag.
p3: - pass return value of helper to rc directly. [Michal Privoznik]
Mao Zhongyi (3): conf/domain_conf: use virStringParseYesNo helper conf/network_conf: use virStringParseYesNo helper qemu/qemu_migration_params: use virStringParseYesNo helper
src/conf/domain_conf.c | 35 ++++++++++++-------------------- src/conf/network_conf.c | 4 +--- src/qemu/qemu_migration_params.c | 7 +------ 3 files changed, 15 insertions(+), 31 deletions(-)
Reviewed-by: Cole Robinson <crobinso@redhat.com> And pushed Thanks, Cole