Re: [libvirt] [PATCH 3/6] Add virtualization type in audit messages

Since a host can run several different virtualization types at the same time, audit messages should allow domains to be identified. Add a 'virt={qemu,kvm,uml,lxc,...}' key to domain audit messages * src/conf/domain_audit.c: Identify virt type of guest --- src/conf/domain_audit.c | 89 ++++++++++++++++++++++++++++++++++++++--------- 1 files changed, 72 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index 20f6ddc..9b7ced7 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -67,6 +67,7 @@ virDomainAuditDisk(virDomainObjPtr vm, char *vmname; char *oldsrc = NULL; char *newsrc = NULL; + const char *virt; virUUIDFormat(vm->def->uuid, uuidstr); if (!(vmname = virAuditEncode("vm", vm->def->name))) { @@ -74,6 +75,11 @@ virDomainAuditDisk(virDomainObjPtr vm, return; } + if (!(virt = virDomainVirtTypeToString(vm->def->virtType))) { + VIR_WARN("Unexpected virt type %d while encoding audit message", vm->def->virtType); + virt = "?"; + }

@@ -88,8 +94,8 @@ virDomainAuditDisk(virDomainObjPtr vm, } VIR_AUDIT(VIR_AUDIT_RECORD_RESOURCE, success, - "resrc=disk reason=%s %s uuid=%s %s %s", - reason, vmname, uuidstr, + "virt=%s resrc=disk reason=%s %s uuid=%s %s %s",