Re: [libvirt] [PATCH RESEND] Distribute only generated virkeymaps.h

On Mon, Oct 05, 2015 at 09:18:41AM +0200, Michal Privoznik wrote: > On 01.10.2015 14:39, Martin Kletzander wrote: >> We are distributing virkeymaps.h and all the tools needed to rebuild >> that file. On top of that, we are generating that file into the >> $(srcdir) and that sometimes fails for me when trying to do make dist in >> VPATH on rawhide fedora. And we don't clean the file when >> maintainer-clean make target is requested. >> >> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; >> ---

>> >> -EXTRA_DIST += $(srcdir)/util/virkeymaps.h $(srcdir)/util/keymaps.csv \ >> - $(srcdir)/util/virkeycode-mapgen.py >> - > > > I am afraid we can't do this. What if somebody wants to 'make dist' > from unpacked .tar.gz? They must have both .csv and .py files. So > you can't really drop them from here. What you can drop is .h file. > Oh so that's probably what Daniel meant in the first proposition of this patch. I misunderstood that. OK, well, I think making dist from unpacked dist doesn't make much sense, but why would we block it, right?