RE: [libvirt][PATCH v6 6/6] add qemu capabilities version 5.2.0

-----Original Message----- From: Peter Krempa <pkrempa(a)redhat.com&gt; Sent: Friday, August 20, 2021 4:10 PM To: Huang, Haibin <haibin.huang(a)intel.com&gt; Cc: libvir-list(a)redhat.com; Ding, Jian-feng <jian-feng.ding(a)intel.com>; Yang, Lin A <lin.a.yang(a)intel.com>; Lu, Lianhao <lianhao.lu(a)intel.com>; pbonzini(a)redhat.com Subject: Re: [libvirt][PATCH v6 6/6] add qemu capabilities version 5.2.0 On Fri, Aug 20, 2021 at 14:15:06 +0800, Haibin Huang wrote: > Signed-off-by: Haibin Huang <haibin.huang(a)intel.com&gt; > --- > docs/schemas/domaincaps.rng | 4 +- > .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 207 + > .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 201 + > tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 207 + > .../caps_5.2.0.x86_64.replies | 29649 ++++++++++++++++ > .../caps_5.2.0.x86_64.xml | 3189 ++ > 6 files changed, 33455 insertions(+), 2 deletions(-) create mode > 100644 tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml > create mode 100644 tests/domaincapsdata/qemu_5.2.0-tcg.x86_64.xml > create mode 100644 tests/domaincapsdata/qemu_5.2.0.x86_64.xml > create mode 100644 > tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies > create mode 100644 tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml This patch doesn't seem to be agains current upstream master. We already do have caps dump for qemu-5.2

> diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng > index a9fd21fcb6..7f7b01ae83 100644 > --- a/docs/schemas/domaincaps.rng > +++ b/docs/schemas/domaincaps.rng > @@ -274,10 +274,10 @@ > <element name='sgx'> > <ref name='supported'/> > <optional> > - <element name='sgx1'> > + <element name='flc'> > <data type='unsignedInt'/> > </element> > - <element name='sgx2'> > + <element name='epc-size'> > <data type='unsignedInt'/> > </element> > </optional> You must not change other things in the patch adding capabilities.