Re: [PATCH v2 3/5] api: add virNetworkCreateFlags
On 9/15/21 1:07 PM, Kristina Hanicova wrote:
Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com>
---
include/libvirt/libvirt-network.h | 4 ++++
src/libvirt-network.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/libvirt/libvirt-network.h b/include/libvirt/libvirt-network.h
index e505c3eb7e..398d8fccd4 100644
--- a/include/libvirt/libvirt-network.h
+++ b/include/libvirt/libvirt-network.h
@@ -113,6 +113,10 @@ virNetworkPtr virNetworkLookupByUUID
(virConnectPtr conn,
virNetworkPtr virNetworkLookupByUUIDString (virConnectPtr conn,
const char *uuid);
+typedef enum {
+ VIR_NETWORK_CREATE_VALIDATE = 1 << 0, /* Validate the XML document against
schema */
Since in patch 4/5 we rely on the fact that VIR_NETWORK_CREATE_VALIDATE
= VIR_NETWORK_DEFINE_VALIDATE should we reflect this in define?
I mean, this could be
VIR_NETWORK_CREATE_VALIDATE = VIR_NETWORK_DEFINE_VALIDATE /* Validate
... */
But since VIR_NETWORK_DEFINE_VALIDATE is declared only after these lines
we would also need to move this typedef :(
Alternatively, we may do G_STATIC_ASSERT(VIR_NETWORK_CREATE_VALIDATE ==
VIR_NETWORK_DEFINE_VALIDATE) somewhere in our code (we can't do it in
public header because that's glib-free).
Michal