On 01/09/2016 08:36 AM, John Ferlan wrote:
v2: http://www.redhat.com/archives/libvir-list/2015-December/msg00766.html
Changes since v2:
Use VIRSH_COMMON_OPT_<optname> for option prefix instead of VIRSH_<optname>_OPT_COMMON
Patches have a few thumbs up already, figured I'd post it one last time for perusal and checks of the naming 'algorithm.
John Ferlan (14): virsh: Covert VSH_POOL_ macro to VIRSH_COMMON_OPT_ virsh: Move VIRSH_COMMON_OPT_POOL to virsh.h virsh: Create macro for common "domain" option virsh: Create macro for common "persistent" option virsh: Create macro for common "config" option virsh: Create macro for common "live" option virsh: Create macro for common "current" option virsh: Create macro for common "file" option virsh: Create macros for common "pool" options virsh: Create macros for common "vol" options virsh: Have domain-monitor use common "domain" option virsh: have snapshot use common "domain" option virsh: Create macro for common "network" option virsh: Create macro for common "interface" option
po/POTFILES.in | 1 + tools/virsh-domain-monitor.c | 77 +--- tools/virsh-domain.c | 911 +++++++++---------------------------------- tools/virsh-interface.c | 37 +- tools/virsh-network.c | 61 +-- tools/virsh-pool.c | 71 ++-- tools/virsh-snapshot.c | 60 +-- tools/virsh-volume.c | 148 ++----- tools/virsh.h | 17 + 9 files changed, 334 insertions(+), 1049 deletions(-)
After performing all the requested fixups, I've now pushed the entire series. Thanks for taking the time to review - I know it was tedius. John