Re: [libvirt] [PATCH] docs: don't install news.rng file

On Wed, Apr 05, 2017 at 07:58:36 +0200, Bjoern Walk wrote: > Daniel P. Berrange <berrange(a)redhat.com&gt; [2017-04-04, 07:24PM +0200]: > > The news.rng file gets picked up by the wildcard match on docs/schemas, > > and so gets installed into /usr/share/libvirt, along with the schemas > > for our API objects. This then generated an RPM build failure, since > > we don't have news.rng in the RPM file list > > > > The news.rng schema is not something that users of libvirt ever care > > about, since it is purely an internal thing to validate our website > > content. > > > > So rather than add news.rng to the RPM file list, this changes the > > make rules so that we don't install news.rng at all. > > > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > > --- > > > > Technically a built-break fix, but I'm not pushing it, in case people > > have any alternative suggestions. eg we could just put news.rng in > > the tests/ subdirectory instead, letting us keep the wildcard in the > > docs/Makefile.am > > I would actually prefer this solution. The current place feels weirdly > wrong. Describe the wrongness please. It's together with other schemas in the directory containing documentation. The place makes sense. Only thing which does not is that it would be installed.

-- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list